Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ui/base/test/run_all_unittests.cc

Issue 457103003: Merge ResourceBundle's InitSharedInstanceLocaleOnly with InitSharedInstanceWithLocale(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/resource/resource_bundle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/test/run_all_unittests.cc
diff --git a/ui/base/test/run_all_unittests.cc b/ui/base/test/run_all_unittests.cc
index bfc5f2603b9310c0fa535df0941093a98eeab092..214df985f6279d9403b171c8a07abaed31093a35 100644
--- a/ui/base/test/run_all_unittests.cc
+++ b/ui/base/test/run_all_unittests.cc
@@ -68,12 +68,14 @@ void UIBaseTestSuite::Initialize() {
// chrome_100_percent.pak at the appropriate places to ui_test.pak.
base::mac::SetOverrideFrameworkBundlePath(
exe_path.AppendASCII("ui_unittests Framework.framework"));
- ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
+ ui::ResourceBundle::InitSharedInstanceWithLocale(
+ "en-US", NULL, u::ResourceBundle::LOAD_COMMON_RESOURCES);
tony 2014/08/12 16:32:50 Typo: Missing i
tfarina 2014/08/13 05:11:43 doing patches at 1:00AM, that is what happens ;)
#elif defined(OS_IOS) || defined(OS_ANDROID)
// On iOS, the ui_unittests binary is itself a mini bundle, with resources
// built in. On Android, ui_unittests_apk provides the necessary framework.
- ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
+ ui::ResourceBundle::InitSharedInstanceWithLocale(
+ "en-US", NULL, u::ResourceBundle::LOAD_COMMON_RESOURCES);
tony 2014/08/12 16:32:50 Same here.
tfarina 2014/08/13 05:11:43 Done.
#else
// On other platforms, the (hardcoded) paths for chrome_100_percent.pak and
« no previous file with comments | « ui/base/resource/resource_bundle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698