Merge ResourceBundle's InitSharedInstanceLocaleOnly with InitSharedInstanceWithLocale().

Merge ResourceBundle's InitSharedInstanceLocaleOnly with InitSharedInstanceWithLocale().

Both methods do almost the same and just difer on whether or not to load
the common resources (aka chrome pak files!).

BUG=340082
TEST=None
R=tony@chromium.org,lambroslambrou@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289435

[tfarina, 2014-08-09 16:01:33]

That will make it easier to do https://codereview.chromium.org/419093002/

[Lambros, 2014-08-09 17:52:11]

rubberstamp lgtm for remoting/

[tony, 2014-08-11 16:25:56]

https://codereview.chromium.org/457103003/diff/1/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/457103003/diff/1/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle.h:132: bool should_load_common_resources);
It would be better if this were an enum { LOAD_COMMON_RESOURCES,
DO_NOT_LOAD_COMMON_RESOURCES } to make the call sites easier to read.

[tfarina, 2014-08-12 04:01:01]

https://codereview.chromium.org/457103003/diff/1/ui/base/resource/resource_bu...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/457103003/diff/1/ui/base/resource/resource_bu...
ui/base/resource/resource_bundle.h:132: bool should_load_common_resources);
On 2014/08/11 16:25:56, tony wrote:
> It would be better if this were an enum { LOAD_COMMON_RESOURCES,
> DO_NOT_LOAD_COMMON_RESOURCES } to make the call sites easier to read.

Done.

[tony, 2014-08-12 16:32:50]

LGTM once the try bots go green.

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
File ui/base/test/run_all_unittests.cc (right):

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
ui/base/test/run_all_unittests.cc:72: "en-US", NULL,
u::ResourceBundle::LOAD_COMMON_RESOURCES);
Typo: Missing i

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
ui/base/test/run_all_unittests.cc:78: "en-US", NULL,
u::ResourceBundle::LOAD_COMMON_RESOURCES);
Same here.

[tfarina, 2014-08-13 05:11:43]

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
File ui/base/test/run_all_unittests.cc (right):

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
ui/base/test/run_all_unittests.cc:72: "en-US", NULL,
u::ResourceBundle::LOAD_COMMON_RESOURCES);
On 2014/08/12 16:32:50, tony wrote:
> Typo: Missing i

doing patches at 1:00AM, that is what happens ;)

fixed.

https://codereview.chromium.org/457103003/diff/40001/ui/base/test/run_all_uni...
ui/base/test/run_all_unittests.cc:78: "en-US", NULL,
u::ResourceBundle::LOAD_COMMON_RESOURCES);
On 2014/08/12 16:32:50, tony wrote:
> Same here.

Done.

[tfarina, 2014-08-13 13:57:01]

TBRing Ben for this.

It is mostly updating callsites with the new parameter.

Tony already reviewed the real changes in ui/base/resource/.

Pushing to CQ!

[tfarina, 2014-08-13 13:59:38]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-08-13 14:01:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/457103003/80001

[commit-bot: I haz the power, 2014-08-13 17:39:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-14 01:05:58]

Committed patchset #5 (80001) as 289435