Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 457063002: Fix v8 landmines script. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix v8 landmines script. Currently, some builders are in a clobber-landmine loop. Clobber deletes the .landmines tracker (sigh). Difficult to know if we are right after a clobber or if it is first-time landmines deployment. Also, a landmine-triggered clobber right after a clobber is not possible. Different clobber methods for msvs, xcode and make all have different blacklists of files that are not deleted. After the branch point, all v8 branch builders have to be manually clobbered, because the appearance of the landmines.py script and the first landmine request are in the same branch CL. TBR=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M build/landmines.py View 1 chunk +22 lines, -22 lines 0 comments Download
M tools/run-tests.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 4 months ago (2014-08-09 08:30:08 UTC) #1
Michael Achenbach
Committed patchset #1 manually as 23012 (tree was closed).
6 years, 4 months ago (2014-08-09 08:31:10 UTC) #2
iannucci
6 years, 4 months ago (2014-08-09 17:20:24 UTC) #3
Message was sent while issue was closed.
sigh, lgtm. There's too many build processes and it's sad that 'clobber' doesn't
really mean `rm -rf out`, which is what it SHOULD mean...

Powered by Google App Engine
This is Rietveld 408576698