Issue 457015: Make the Flip suppression more generic to cover mac too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 457015: Make the Flip suppression more generic to cover mac too. (Closed)

Created:
11 years ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
jamesr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make the Flip suppression more generic to cover mac too. BUG=http://crbug.com/29026 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33384

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

11 years ago (2009-12-01 00:11:51 UTC) #2

LGTM, but it should be BUG=29004

http://codereview.chromium.org/457015/diff/1/2
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/457015/diff/1/2#newcode1828
tools/valgrind/memcheck/suppressions.txt:1828: bug_29026
29026 was merged into 29004, could you change that as well?

Expand Messages | Collapse Messages