Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2307)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 457013002: Avoid absoluteImageURL() creating data URLs for canvas by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix failing copyImageAt unit test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 8a6d06f5136d659721de230a5aa6547202e5e9c6..508356b5c3f3f821e10bea7b7634887cc48eed55 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3259,7 +3259,7 @@ void WebViewImpl::copyImageAt(const WebPoint& point)
HitTestResult result = hitTestResultForWindowPos(point);
- if (result.absoluteImageURL().isEmpty()) {
+ if (result.absoluteImageURLIncludingCanvasDataURL().isEmpty()) {
// There isn't actually an image at these coordinates. Might be because
// the window scrolled while the context menu was open or because the page
// changed itself between when we thought there was an image here and when
@@ -3278,7 +3278,7 @@ void WebViewImpl::saveImageAt(const WebPoint& point)
if (!m_page)
return;
- KURL url = hitTestResultForWindowPos(point).absoluteImageURL();
+ KURL url = hitTestResultForWindowPos(point).absoluteImageURLIncludingCanvasDataURL();
if (url.isEmpty())
return;
« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698