Make landmines work on local builds too

build/gyp_chromium

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script is wrapper for Chromium that adds some support for how GYP
 # is invoked by Chromium beyond what can be done in the gclient hooks.
 
 import glob
-import gyp_helper
+import gyp_environment
 import os
 import re
 import shlex
 import subprocess
 import string
 import sys
 import vs_toolchain
 
 script_dir = os.path.dirname(os.path.realpath(__file__))
 chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
@@ skipping 170 matching lines @@
   # TODO(sky): remove analyzer2 once updated recipes.
   use_analyzer = len(args) and (args[0] == '--analyzer' or
                                 args[0] == '--analyzer2')
   if use_analyzer:
     args.pop(0)
     os.environ['GYP_GENERATORS'] = 'analyzer'
     args.append('-Gconfig_path=' + args.pop(0))
     args.append('-Ganalyzer_output_path=' + args.pop(0))
 
   if int(os.environ.get('GYP_CHROMIUM_NO_ACTION', 0)):
-    # Check for landmines (reasons to clobber the build) in any case.
-    print 'Running build/landmines.py...'
-    subprocess.check_call(
-        [sys.executable, os.path.join(script_dir, 'landmines.py')])
     print 'Skipping gyp_chromium due to GYP_CHROMIUM_NO_ACTION env var.'
     sys.exit(0)
 
   # Use the Psyco JIT if available.
   if psyco:
     psyco.profile()
     print "Enabled Psyco JIT."
 
   # Fall back on hermetic python if we happen to get run under cygwin.
   # TODO(bradnelson): take this out once this issue is fixed:
   #    http://code.google.com/p/gyp/issues/detail?id=177
   if sys.platform == 'cygwin':
     import find_depot_tools
     depot_tools_path = find_depot_tools.add_depot_tools_to_path()
     python_dir = sorted(glob.glob(os.path.join(depot_tools_path,
                                                'python2*_bin')))[-1]
     env = os.environ.copy()
     env['PATH'] = python_dir + os.pathsep + env.get('PATH', '')
     p = subprocess.Popen(
        [os.path.join(python_dir, 'python.exe')] + sys.argv,
        env=env, shell=False)
     p.communicate()
     sys.exit(p.returncode)
 
-  gyp_helper.apply_chromium_gyp_env()
-
   # This could give false positives since it doesn't actually do real option
   # parsing.  Oh well.
   gyp_file_specified = False
   for arg in args:
     if arg.endswith('.gyp'):
       gyp_file_specified = True
       break
 
   # If we didn't get a file, check an env var, and then fall back to
   # assuming 'all.gyp' from the same directory as the script.
   if not gyp_file_specified:
     gyp_file = os.environ.get('CHROMIUM_GYP_FILE')
     if gyp_file:
       # Note that CHROMIUM_GYP_FILE values can't have backslashes as
       # path separators even on Windows due to the use of shlex.split().
       args.extend(shlex.split(gyp_file))
     else:
       args.append(os.path.join(script_dir, 'all.gyp'))
 
+  vs2013_runtime_dll_dirs = gyp_environment.SetEnvironment()
+
   # There shouldn't be a circular dependency relationship between .gyp files,
   # but in Chromium's .gyp files, on non-Mac platforms, circular relationships
   # currently exist.  The check for circular dependencies is currently
   # bypassed on other platforms, but is left enabled on the Mac, where a
   # violation of the rule causes Xcode to misbehave badly.
   # TODO(mark): Find and kill remaining circular dependencies, and remove this
   # option.  http://crbug.com/35878.
   # TODO(tc): Fix circular dependencies in ChromiumOS then add linux2 to the
   # list.
   if sys.platform not in ('darwin',):
     args.append('--no-circular-check')
 
   # We explicitly don't support the make gyp generator (crbug.com/348686). Be
   # nice and fail here, rather than choking in gyp.
   if re.search(r'(^|,|\s)make($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
     print 'Error: make gyp generator not supported (check GYP_GENERATORS).'
     sys.exit(1)
 
-  # Default to ninja on linux and windows, but only if no generator has
-  # explicitly been set.
-  # Also default to ninja on mac, but only when not building chrome/ios.
-  # . -f / --format has precedence over the env var, no need to check for it
-  # . set the env var only if it hasn't been set yet
-  # . chromium.gyp_env has been applied to os.environ at this point already
-  if sys.platform.startswith(('linux', 'win', 'freebsd')) and \
-      not os.environ.get('GYP_GENERATORS'):
-    os.environ['GYP_GENERATORS'] = 'ninja'
-  elif sys.platform == 'darwin' and not os.environ.get('GYP_GENERATORS') and \
-      not 'OS=ios' in os.environ.get('GYP_DEFINES', []):
-    os.environ['GYP_GENERATORS'] = 'ninja'
-
-  vs2013_runtime_dll_dirs = vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
-
   # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
   # to enfore syntax checking.
   syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
   if syntax_check and int(syntax_check):
     args.append('--check')
 
   supplemental_includes = GetSupplementalFiles()

[scottmg, 2014/08/12 17:22:12]

All this stuff could/should be moved to gyp_environment.py too, but
landmine_utils.py already doesn't see these (as they go into command line
arguments, not GYP_DEFINES, e.g.) so it's no worse than it was before. (And I'm
a little scared to move this stuff around because there's so many ways to break
people's random setups and no tests or bots.)

   gyp_vars_dict = GetGypVars(supplemental_includes)
 
   # TODO(dmikurube): Remove these checks and messages after a while.
   if ('linux_use_tcmalloc' in gyp_vars_dict or
       'android_use_tcmalloc' in gyp_vars_dict):
     print '*****************************************************************'
     print '"linux_use_tcmalloc" and "android_use_tcmalloc" are deprecated!'
     print '-----------------------------------------------------------------'
     print 'You specify "linux_use_tcmalloc" or "android_use_tcmalloc" in'
     print 'your GYP_DEFINES. Please switch them into "use_allocator" now.'
@@ skipping 16 matching lines @@
   args.extend(['-D', 'gyp_output_dir=' + GetOutputDirectory()])
 
   if not use_analyzer:
     print 'Updating projects from gyp files...'
     sys.stdout.flush()
 
   # Off we go...
   gyp_rc = gyp.main(args)
 
   if not use_analyzer:
-    # Check for landmines (reasons to clobber the build). This must be run here,
-    # rather than a separate runhooks step so that any environment modifications
-    # from above are picked up.
-    print 'Running build/landmines.py...'
-    subprocess.check_call(
-      [sys.executable, os.path.join(script_dir, 'landmines.py')])
-
     if vs2013_runtime_dll_dirs:
       x64_runtime, x86_runtime = vs2013_runtime_dll_dirs
       vs_toolchain.CopyVsRuntimeDlls(
         os.path.join(chrome_src, GetOutputDirectory()),
         (x86_runtime, x64_runtime))
 
   sys.exit(gyp_rc)