Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 457003002: [site isolation] cross-site transfers should track the RenderFrameHost, not the View (Closed)

Created:
6 years, 4 months ago by ncarter (slow)
Modified:
6 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

site isolation: cross-site transfers should track the RenderFrameHost, not the View This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap. 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames. 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating. 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state. BUG=304341, 400850 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867

Patch Set 1 #

Patch Set 2 : Self-review fixes; repair content_unittests; add a pending_main_test_rfh to the test apparatus. #

Patch Set 3 : Formatting #

Patch Set 4 : Self-review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -172 lines) Patch
M content/browser/cross_site_request_manager.h View 3 chunks +13 lines, -13 lines 0 comments Download
M content/browser/cross_site_request_manager.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 3 chunks +48 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 6 chunks +47 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 7 chunks +13 lines, -20 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +0 lines, -48 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 5 chunks +0 lines, -45 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 chunks +19 lines, -20 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 2 1 chunk +13 lines, -3 lines 0 comments Download
M content/test/test_render_view_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ncarter (slow)
Charlie, please have a look
6 years, 4 months ago (2014-08-09 07:20:59 UTC) #1
Charlie Reis
Very nice. LGTM!
6 years, 4 months ago (2014-08-11 17:35:16 UTC) #2
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 4 months ago (2014-08-11 17:42:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/457003002/60001
6 years, 4 months ago (2014-08-11 17:45:02 UTC) #4
commit-bot: I haz the power
Change committed as 288867
6 years, 4 months ago (2014-08-12 01:45:00 UTC) #5
pkotwicz
6 years, 4 months ago (2014-08-12 19:22:43 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/462083003/ by pkotwicz@chromium.org.

The reason for reverting is: Speculatively reverting CL in case it is causing
WebNavigationApiTest.OpenTab to fail
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....

Powered by Google App Engine
This is Rietveld 408576698