Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 457001: Merge 33287 - Mac: improve apparent zorder problems when switching Spaces.... (Closed)

Created:
11 years ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 33287 - Mac: improve apparent zorder problems when switching Spaces. Remove the status bubble as child window when hidden, rather than just setting its opacity to 0. I'm not sure about the effects, if any, of doing this rather than destroying the window completely. This doesn't eliminate zorder problems with Spaces, but should improve it considerably. This may also ameliorate the problems with moving windows between Spaces using Expose. BUG=28107, 24956 TEST=Create a bunch of windows; get the status bubble to appear in the active (key) window and then get it to disappear; switch to another spaces and back; make sure the active window is on top; repeat. Review URL: http://codereview.chromium.org/434120 TBR=pinkerton@chromium.org, thakis@chromium.org, viettrungluu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M chrome/browser/cocoa/chrome_event_processing_window.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/status_bubble_mac.h View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/cocoa/status_bubble_mac.mm View 5 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
11 years ago (2009-11-30 17:44:56 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698