Remove unnecessary "extensions::" prefix in guest_view/web_view/app_view directories.

Remove unnecessary "extensions::" prefix in web_view/app_view directories.

BUG=352290
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289324

[Xi Han, 2014-08-12 20:18:45]

Forgot to remove these "extensions::" prefix in my last CL. I am wondering why I
didn't get any compile error at that time, but I do get compile errors after I
rebase another patch that I am working on now.

[Fady Samuel, 2014-08-12 21:25:31]

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.cc (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:112: const {
can this now go on the line above?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:158:
service->GetExtensionById(app_id, false);
Can this go on the previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:160:
service->GetExtensionById(embedder_extension_id, false);
can this go on the previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.cc (right):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:156:
ExtensionSystem::Get(browser_context())->extension_service();
Can this go on the previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:176:
ExtensionSystem::Get(browser_context())->
Move to previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:237:
ExtensionSystem::Get(browser_context());
Move to previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.h (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.h:76:
extension_function_dispatcher_;
This can probably now go on the same line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/web_view/web_view_guest.cc:339: new
ScriptExecutor(guest_web_contents(), &script_observers_));
Can this go on the previous line?

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/web_view/web_view_guest.h (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/web_view/web_view_guest.h:340: script_observers_;
Move to previous line?

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:112:
FeatureProvider::GetAPIFeatures()->GetFeature(
Move to previous line?

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:120:
ExtensionRegistry::Get(browser_context_)
Move to previous line?

[Xi Han, 2014-08-12 21:53:49]

Thanks for catching up these spacing issues.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.cc (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:112: const {
On 2014/08/12 21:25:30, Fady Samuel wrote:
> can this now go on the line above?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:158:
service->GetExtensionById(app_id, false);
On 2014/08/12 21:25:29, Fady Samuel wrote:
> Can this go on the previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:160:
service->GetExtensionById(embedder_extension_id, false);
On 2014/08/12 21:25:29, Fady Samuel wrote:
> can this go on the previous line?


This line exceeds the limits.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.cc (right):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:156:
ExtensionSystem::Get(browser_context())->extension_service();
On 2014/08/12 21:25:29, Fady Samuel wrote:
> Can this go on the previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:176:
ExtensionSystem::Get(browser_context())->
On 2014/08/12 21:25:29, Fady Samuel wrote:
> Move to previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.cc:237:
ExtensionSystem::Get(browser_context());
On 2014/08/12 21:25:30, Fady Samuel wrote:
> Move to previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/app_view/app_view_guest.h (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/app_view/app_view_guest.h:76:
extension_function_dispatcher_;
On 2014/08/12 21:25:30, Fady Samuel wrote:
> This can probably now go on the same line?

Done.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/web_view/web_view_guest.cc:339: new
ScriptExecutor(guest_web_contents(), &script_observers_));
On 2014/08/12 21:25:30, Fady Samuel wrote:
> Can this go on the previous line?

This line exceeds the limit.

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
File chrome/browser/guest_view/web_view/web_view_guest.h (left):

https://codereview.chromium.org/456983003/diff/40001/chrome/browser/guest_vie...
chrome/browser/guest_view/web_view/web_view_guest.h:340: script_observers_;
On 2014/08/12 21:25:30, Fady Samuel wrote:
> Move to previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:112:
FeatureProvider::GetAPIFeatures()->GetFeature(
On 2014/08/12 21:25:30, Fady Samuel wrote:
> Move to previous line?

Done.

https://codereview.chromium.org/456983003/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:120:
ExtensionRegistry::Get(browser_context_)
On 2014/08/12 21:25:30, Fady Samuel wrote:
> Move to previous line?

Done.

[Fady Samuel, 2014-08-13 13:52:18]

lgtm

[Xi Han, 2014-08-13 14:12:11]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2014-08-13 14:13:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hanxi@chromium.org/456983003/120001

[commit-bot: I haz the power, 2014-08-13 17:02:28]

Committed patchset #5 (120001) as 289324