Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: runtime/vm/message_handler.cc

Issue 456983002: Refactor isolate startup code in preparation for making isolate spawning more truly non-blocking. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/message_handler.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message_handler.cc
diff --git a/runtime/vm/message_handler.cc b/runtime/vm/message_handler.cc
index 8bc3eb9cfafea8960d1c644045a29b1ceb2f38cc..e5990fbbcfab92a924fa2664000b8309659a9741 100644
--- a/runtime/vm/message_handler.cc
+++ b/runtime/vm/message_handler.cc
@@ -34,7 +34,6 @@ class MessageHandlerTask : public ThreadPool::Task {
MessageHandler::MessageHandler()
: queue_(new MessageQueue()),
oob_queue_(new MessageQueue()),
- control_ports_(0),
live_ports_(0),
paused_(0),
pause_on_start_(false),
@@ -272,8 +271,8 @@ void MessageHandler::ClosePort(Dart_Port port) {
OS::Print("[-] Closing port:\n"
"\thandler: %s\n"
"\tport: %" Pd64 "\n"
- "\tports: control(%" Pd ") live(%" Pd ")\n",
- name(), port, control_ports_, live_ports_);
+ "\tports: live(%" Pd ")\n",
+ name(), port, live_ports_);
}
}
@@ -307,22 +306,4 @@ void MessageHandler::decrement_live_ports() {
live_ports_--;
}
-
-void MessageHandler::increment_control_ports() {
- MonitorLocker ml(&monitor_);
-#if defined(DEBUG)
- CheckAccess();
-#endif
- control_ports_++;
-}
-
-
-void MessageHandler::decrement_control_ports() {
- MonitorLocker ml(&monitor_);
-#if defined(DEBUG)
- CheckAccess();
-#endif
- control_ports_--;
-}
-
} // namespace dart
« no previous file with comments | « runtime/vm/message_handler.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698