Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456963002: Delete RenderLayer::setHasVisibleContent (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
esprehn, skobes
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, eseidel, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Delete RenderLayer::setHasVisibleContent This function cleans out a single dirty bit in the RenderLayer tree without cleaning the entire subtree, which breaks the invariant that dirty bits represent are connected up to the root of the tree. Fortunately, this function isn't needed any longer. This CL also fixed a bug whereby we'd issue invalidations for the previous location of an element that became visible. That can manifest as a bug if the element moves after becoming visible or if the old rect exists in another graphics layer. R=esprehn@chromium.org, skobes@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180007

Patch Set 1 #

Patch Set 2 : Call setPreviousPaintInvalidationRect #

Patch Set 3 : Improve repainting #

Patch Set 4 : Now with tests #

Patch Set 5 : Rebaseline inspector test #

Total comments: 2

Patch Set 6 : moar #

Patch Set 7 : Remove dangling declaration #

Messages

Total messages: 12 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-08-08 22:14:57 UTC) #1
skobes
lgtm
6 years, 4 months ago (2014-08-08 22:39:52 UTC) #2
abarth-chromium
+esprehn I've changed this CL a bit since skobes reviewed it. It's probably worth reviewing ...
6 years, 4 months ago (2014-08-11 20:47:54 UTC) #3
esprehn
https://codereview.chromium.org/456963002/diff/80001/LayoutTests/fast/repaint/dont-invalidate-root-layer-when-composited-layer-becomes-visible.html File LayoutTests/fast/repaint/dont-invalidate-root-layer-when-composited-layer-becomes-visible.html (right): https://codereview.chromium.org/456963002/diff/80001/LayoutTests/fast/repaint/dont-invalidate-root-layer-when-composited-layer-becomes-visible.html#newcode1 LayoutTests/fast/repaint/dont-invalidate-root-layer-when-composited-layer-becomes-visible.html:1: <html> no doctype :( https://codereview.chromium.org/456963002/diff/80001/LayoutTests/fast/repaint/invalidate-invisible-element.html File LayoutTests/fast/repaint/invalidate-invisible-element.html (right): https://codereview.chromium.org/456963002/diff/80001/LayoutTests/fast/repaint/invalidate-invisible-element.html#newcode1 ...
6 years, 4 months ago (2014-08-11 20:51:57 UTC) #4
abarth-chromium
Done!
6 years, 4 months ago (2014-08-11 20:54:11 UTC) #5
esprehn
lgtm
6 years, 4 months ago (2014-08-11 20:54:56 UTC) #6
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-11 21:37:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/456963002/120001
6 years, 4 months ago (2014-08-11 21:38:49 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 22:44:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 23:20:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22140)
6 years, 4 months ago (2014-08-11 23:20:32 UTC) #11
abarth-chromium
6 years, 4 months ago (2014-08-11 23:30:36 UTC) #12
Message was sent while issue was closed. 
Committed patchset #7 manually as 180007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698