Also declare the transport_security_state_ member as const.

net/quic/crypto/proof_verifier_chromium.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_PROOF_VERIFIER_CHROMIUM_H_
 #define NET_QUIC_CRYPTO_PROOF_VERIFIER_CHROMIUM_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 61 matching lines @@
  private:
   class Job;
   typedef std::set<Job*> JobSet;
 
   void OnJobComplete(Job* job);
 
   // Set owning pointers to active jobs.
   JobSet active_jobs_;
 
   // Underlying verifier used to verify certificates.
   CertVerifier* const cert_verifier_;

[wtc, 2014/08/08 21:59:17]

I noticed that the cert_verifier_ member is const, so I think the related
transport_security_state_ member should also be const.

[Ryan Hamilton, 2014/08/08 22:08:22]

This means that the pointer never changes, but the object pointed to can change,
right? Personally, I think I'd end up confused by the meaning of const here, but
since we did this for the cert_verifier_ we might as well be consistent.

[wtc, 2014/08/13 18:37:35]

That's correct.
This use of 'const' tells a code reviewer that these members won't change once
initialized. I didn't use 'const' this way before but gradually started to like
it. I did notice that even the people who like to use 'const' this way often
neglect to add 'const' to pointer members.

Would you like me to remove 'const' from both of these members?

 
-  TransportSecurityState* transport_security_state_;
+  TransportSecurityState* const transport_security_state_;
 
   DISALLOW_COPY_AND_ASSIGN(ProofVerifierChromium);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_PROOF_VERIFIER_CHROMIUM_H_