ui/views/widget/native_widget_aura.cc - Issue 456943004: Fix SetShape (SetAlphaShape) to allow Null regions (+ tests).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 456943004: Fix SetShape (SetAlphaShape) to allow Null regions (+ tests). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/native_widget_aura.cc

diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc

index e57a4ff0bc0ecb56c12fba415058f0d60a13b85f..2f6c5c3b317c8740edc7e5471dfda9d1ad4235b0 100644

--- a/ui/views/widget/native_widget_aura.cc

+++ b/ui/views/widget/native_widget_aura.cc

@@ -439,7 +439,8 @@ void NativeWidgetAura::StackBelow(gfx::NativeView native_view) {

void NativeWidgetAura::SetShape(gfx::NativeRegion region) {

// No need for this. Just delete and ignore.

- delete region;

+ if (region)

sky 2014/08/11 15:26:37 no need for the if.

garykac 2014/08/11 18:19:09 Done.

+ delete region;

}

void NativeWidgetAura::Close() {