Add ExternalPrerenderRequestHandler and related API

chrome/browser/android/external_prerender_request_handler.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/external_prerender_request_handler.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
+#include "base/strings/string16.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/prerender/prerender_handle.h"
+#include "chrome/browser/prerender/prerender_manager.h"
+#include "chrome/browser/prerender/prerender_manager_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "content/public/browser/web_contents.h"
+
+#include "jni/ExternalPrerenderRequestHandler_jni.h"
+
+using base::android::AttachCurrentThread;

[Yaron, 2013/10/25 23:32:44]

unused

[Yusuf, 2013/10/29 05:34:11]

Done.

+using base::android::ConvertJavaStringToUTF16;
+using content::WebContents;

[Yaron, 2013/10/25 23:32:44]

inline

[Yusuf, 2013/10/29 05:34:11]

Done.

+
+using prerender::PrerenderManager;

[Yaron, 2013/10/25 23:32:44]

I think your code should be in the prerender namespace

[Yusuf, 2013/10/29 05:34:11]

Done.

+
+int ExternalPrerenderRequestHandler::AddPrerender(JNIEnv* env,
+                                                  jobject obj,
+                                                  jstring jurl,
+                                                  jstring jreferrer,
+                                                  jint width,
+                                                  jint height) {
+  Profile* profile = g_browser_process->profile_manager()->GetDefaultProfile();

[Yaron, 2013/10/25 23:32:44]

Pass this in.

[Yusuf, 2013/10/29 05:34:11]

Done.

+
+  GURL gurl = GURL(ConvertJavaStringToUTF16(env, jurl));
+  if (!gurl.is_valid())
+    return 0;
+
+  GURL referrer_url = GURL(ConvertJavaStringToUTF16(env, jreferrer));
+  content::Referrer referrer = referrer_url.is_valid() ?
+      content::Referrer(referrer_url, WebKit::WebReferrerPolicyDefault) :
+      content::Referrer();
+
+  PrerenderManager* prerender_manager = GetPrerenderManager();
+  WebContents* web_contents =
+      content::WebContents::Create(WebContents::CreateParams(profile));
+  if (prerender_handle_.get()) {
+    prerender_handle_->OnNavigateAway();
+    // The PrerenderHandle is now owned by the PrerenderManager.
+    ignore_result(prerender_handle_.release());
+  }
+  prerender_handle_.reset(
+      prerender_manager->AddPrerenderFromExternalRequest(
+          gurl,
+          referrer,
+          web_contents->GetController().GetDefaultSessionStorageNamespace(),
+          gfx::Size(width, height)));
+  if (!prerender_handle_)
+    return 0;
+  return reinterpret_cast<jint>(web_contents);
+}
+
+PrerenderManager* ExternalPrerenderRequestHandler::GetPrerenderManager() const {
+  Profile* profile = g_browser_process->profile_manager()->GetDefaultProfile();
+  return prerender::PrerenderManagerFactory::GetForProfile(profile);

[Yaron, 2013/10/25 23:32:44]

Inline this (you only need this line)

[Yusuf, 2013/10/29 05:34:11]

Done.

+}
+
+ExternalPrerenderRequestHandler::ExternalPrerenderRequestHandler() {
+}
+
+ExternalPrerenderRequestHandler::~ExternalPrerenderRequestHandler() {
+  if (prerender_handle_.get())

[Yaron, 2013/10/25 23:32:44]

Hmm. The destructor is never called. so this is kind of dead code. You could
switch this to just be a util function as I mentioned in the internal review

[Yusuf, 2013/10/29 05:34:11]

Done.

+    prerender_handle_->OnCancel();
+}
+
+static jint Init(JNIEnv* env,
+                 jclass clazz) {
+  return reinterpret_cast<jint>(new ExternalPrerenderRequestHandler());
+}
+
+bool ExternalPrerenderRequestHandler::RegisterExternalPrerenderRequestHandler(
+    JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}