Issue 456923002: Metrics: Claim ownership of the Linux.GlibcVersion histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456923002: Metrics: Claim ownership of the Linux.GlibcVersion histogram. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 4 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Metrics: Claim ownership of the Linux.GlibcVersion histogram. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288488

Patch Set 2 : Address comment, pretty print. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	tools/metrics/histograms/histograms.xml	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

LGTM with nit, thanks! https://codereview.chromium.org/456923002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/456923002/diff/1/tools/metrics/histograms/histograms.xml#oldcode10298 tools/metrics/histograms/histograms.xml:10298: <summary>The version of glibc used. ...

6 years, 4 months ago (2014-08-08 21:44:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/456923002/20001

6 years, 4 months ago (2014-08-08 21:57:51 UTC) #4

Message was sent while issue was closed.

Change committed as 288488

Expand Messages | Collapse Messages

Issue 456923002: Metrics: Claim ownership of the Linux.GlibcVersion histogram. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment, pretty print. #

Messages