Issue 456853002: Break labels apart in preloaded list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456853002: Break labels apart in preloaded list. (Closed)

Created:
6 years, 4 months ago by agl

Modified:
6 years, 4 months ago

Reviewers:
palmer

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Break labels apart in preloaded list. Since the hosts are stored in DNS wire format (with length-prefixed labels), any labels that start with a digit cause an escape like "\0071..." (that's length=7, first byte of the label = "1"). But this causes a warning in Visual Studio and breaks the build. This change splits the length bytes from the labels so that this warning doesn't happen. BUG=none R=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288443

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+638 lines, -638 lines)			Patch
	M	net/http/transport_security_state_static.h	View		1 chunk	+638 lines, -638 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

palmer

LGTM It would have been OK to just fix it in the 1 place where ...

6 years, 4 months ago (2014-08-08 20:38:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/456853002/1

6 years, 4 months ago (2014-08-08 20:40:23 UTC) #4

agl

6 years, 4 months ago (2014-08-08 21:47:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 288443 (presubmit successful).

Expand Messages | Collapse Messages