Issue 456843004: Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456843004: Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering." (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer, Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering." Breaks compilation on Mac64 | TEST=compiler-unittests | R=jarin@chromium.org | | Committed: https://code.google.com/p/v8/source/detail?r=23077 TBR=bmeurer@chromium.org,jarin@chromium.org LOG=n BUG=none Committed: https://code.google.com/p/v8/source/detail?r=23079

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+207 lines, -309 lines)			Patch
M	src/compiler/change-lowering.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/compiler/common-node-cache.h	View	3 chunks	+6 lines, -14 lines	0 comments	Download
M	src/compiler/node-cache.h	View	2 chunks	+10 lines, -18 lines	0 comments	Download
M	src/compiler/node-cache.cc	View	4 chunks	+24 lines, -12 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/cctest/compiler/test-node-cache.cc	View	1 chunk	+160 lines, -0 lines	0 comments	Download
D	test/compiler-unittests/common-node-cache-unittest.cc	View	1 chunk	+0 lines, -125 lines	0 comments	Download
M	test/compiler-unittests/compiler-unittests.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	test/compiler-unittests/node-cache-unittest.cc	View	1 chunk	+0 lines, -129 lines	0 comments	Download
M	testing/gtest-type-names.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

jochen (gone - plz use gerrit)

6 years, 4 months ago (2014-08-12 12:53:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as 23079 (tree was closed).