Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 456843004: Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering." (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert 23077 - "Use CommonNodeCache for heap constants in ChangeLowering." Breaks compilation on Mac64 | TEST=compiler-unittests | R=jarin@chromium.org | | Committed: https://code.google.com/p/v8/source/detail?r=23077 TBR=bmeurer@chromium.org,jarin@chromium.org LOG=n BUG=none Committed: https://code.google.com/p/v8/source/detail?r=23079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -309 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/common-node-cache.h View 3 chunks +6 lines, -14 lines 0 comments Download
M src/compiler/node-cache.h View 2 chunks +10 lines, -18 lines 0 comments Download
M src/compiler/node-cache.cc View 4 chunks +24 lines, -12 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-node-cache.cc View 1 chunk +160 lines, -0 lines 0 comments Download
D test/compiler-unittests/common-node-cache-unittest.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M test/compiler-unittests/compiler-unittests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D test/compiler-unittests/node-cache-unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M testing/gtest-type-names.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-12 12:53:03 UTC) #1
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-12 12:53:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as 23079 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698