Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.h

Issue 456843003: Remove protected virtual methods from BaseSearchProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/zero_suggest_provider.h
diff --git a/chrome/browser/autocomplete/zero_suggest_provider.h b/chrome/browser/autocomplete/zero_suggest_provider.h
index 5c7b9f7287cea6d4d3c9a526ea3dea91a910d6ba..71567c1765af815556bdca8f89da2e90370f9d9b 100644
--- a/chrome/browser/autocomplete/zero_suggest_provider.h
+++ b/chrome/browser/autocomplete/zero_suggest_provider.h
@@ -63,16 +63,13 @@ class ZeroSuggestProvider : public BaseSearchProvider,
// AutocompleteProvider:
virtual void Start(const AutocompleteInput& input,
bool minimal_changes) OVERRIDE;
+ virtual void Stop(bool clear_cached_results) OVERRIDE;
virtual void DeleteMatch(const AutocompleteMatch& match) OVERRIDE;
+ virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;
// Sets |field_trial_triggered_| to false.
virtual void ResetSession() OVERRIDE;
- protected:
- // BaseSearchProvider:
- virtual void ModifyProviderInfo(
- metrics::OmniboxEventProto_ProviderInfo* provider_info) const OVERRIDE;
-
private:
ZeroSuggestProvider(AutocompleteProviderListener* listener,
TemplateURLService* template_url_service,
@@ -80,18 +77,11 @@ class ZeroSuggestProvider : public BaseSearchProvider,
virtual ~ZeroSuggestProvider();
- // BaseSearchProvider:
- virtual const TemplateURL* GetTemplateURL(bool is_keyword) const OVERRIDE;
- virtual const AutocompleteInput GetInput(bool is_keyword) const OVERRIDE;
- virtual bool ShouldAppendExtraParams(
- const SearchSuggestionParser::SuggestResult& result) const OVERRIDE;
- virtual void StopSuggest() OVERRIDE;
- virtual void ClearAllResults() OVERRIDE;
- virtual void RecordDeletionResult(bool success) OVERRIDE;
-
// net::URLFetcherDelegate:
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+ AutocompleteInput GetInput() const;
+
// Optionally, cache the received |json_data| and return true if we want
// to stop processing results at this point. The |parsed_data| is the parsed
// version of |json_data| used to determine if we received an empty result.

Powered by Google App Engine
This is Rietveld 408576698