Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 456843003: Remove protected virtual methods from BaseSearchProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index d7be6bf878ddb824e3321dd1da30c6541f97bce4..1c7b0f21759f22b050d572e07415efd59c9d98da 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -160,19 +160,31 @@ class SearchProvider : public BaseSearchProvider,
// AutocompleteProvider:
virtual void Start(const AutocompleteInput& input,
bool minimal_changes) OVERRIDE;
-
- // BaseSearchProvider:
- virtual const TemplateURL* GetTemplateURL(bool is_keyword) const OVERRIDE;
- virtual const AutocompleteInput GetInput(bool is_keyword) const OVERRIDE;
- virtual bool ShouldAppendExtraParams(
- const SearchSuggestionParser::SuggestResult& result) const OVERRIDE;
- virtual void StopSuggest() OVERRIDE;
- virtual void ClearAllResults() OVERRIDE;
- virtual void RecordDeletionResult(bool success) OVERRIDE;
+ virtual void Stop(bool clear_cached_results) OVERRIDE;
// net::URLFetcherDelegate:
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+ // Returns the TemplateURL corresponding to the keyword or default
+ // provider based on the value of |is_keyword|.
+ const TemplateURL* GetTemplateURL(bool is_keyword) const;
+
+ // Returns the AutocompleteInput for keyword provider or default provider
+ // based on the value of |is_keyword|.
+ const AutocompleteInput& GetInput(bool is_keyword) const;
+
+ // Returns whether the destination URL corresponding to the given |result|
+ // should contain command-line-specified query params.
+ bool ShouldAppendExtraParams(
+ const SearchSuggestionParser::SuggestResult& result) const;
+
+ // Stops the suggest query.
+ // NOTE: This does not update |done_|. Callers must do so.
+ void StopSuggest();
+
+ // Clears the current results.
+ void ClearAllResults();
+
// Recalculates the match contents class of |results| to better display
// against the current input and user's language.
void UpdateMatchContentsClass(const base::string16& input_text,

Powered by Google App Engine
This is Rietveld 408576698