Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 456813002: Do not migrate NetworkPrediction preference on Android. (Closed)

Created:
6 years, 4 months ago by Bence
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not migrate NetworkPrediction preference on Android. Do not call chrome_browser_net::MigrateNetworkPredictionUserPrefs() on Android, because preference migration from kNetworkPredictionEnabled to kNetworkPredictionOptions is carried out by some platform-specific code on Android. BUG=334602 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288714

Patch Set 1 #

Total comments: 2

Patch Set 2 : Specify TODO timeframe in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Bence
bauerb: PTAL. Thank you.
6 years, 4 months ago (2014-08-08 14:48:18 UTC) #1
Bernhard Bauer
lgtm https://codereview.chromium.org/456813002/diff/1/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/456813002/diff/1/chrome/browser/prefs/browser_prefs.cc#newcode533 chrome/browser/prefs/browser_prefs.cc:533: // TODO(bnc): https://crbug.com/401970 Remove migration code after some ...
6 years, 4 months ago (2014-08-11 09:01:34 UTC) #2
Bence
Thanks. https://codereview.chromium.org/456813002/diff/1/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/456813002/diff/1/chrome/browser/prefs/browser_prefs.cc#newcode533 chrome/browser/prefs/browser_prefs.cc:533: // TODO(bnc): https://crbug.com/401970 Remove migration code after some ...
6 years, 4 months ago (2014-08-11 13:39:45 UTC) #3
Bence
The CQ bit was checked by bnc@chromium.org
6 years, 4 months ago (2014-08-11 13:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/456813002/20001
6 years, 4 months ago (2014-08-11 13:41:30 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 15:16:20 UTC) #6
Message was sent while issue was closed.
Change committed as 288714

Powered by Google App Engine
This is Rietveld 408576698