Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 456793002: Fixing the enhanced bookmark namespace. (Closed)

Created:
6 years, 4 months ago by noyau (Ping after 24h)
Modified:
6 years, 3 months ago
Reviewers:
blundell
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fixing the enhanced bookmark namespace. BUG=None Committed: https://crrev.com/9da9612482b2028dff0f1caca783878e8aa82abc Cr-Commit-Position: refs/heads/master@{#292150}

Patch Set 1 #

Total comments: 2

Patch Set 2 : With an 's' this time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M components/enhanced_bookmarks/enhanced_bookmark_utils.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
noyau (Ping after 24h)
6 years, 4 months ago (2014-08-08 14:09:57 UTC) #1
blundell
https://codereview.chromium.org/456793002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h File components/enhanced_bookmarks/enhanced_bookmark_utils.h (right): https://codereview.chromium.org/456793002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h#newcode15 components/enhanced_bookmarks/enhanced_bookmark_utils.h:15: namespace enhanced_bookmark { enhanced_bookmarks
6 years, 4 months ago (2014-08-12 14:04:15 UTC) #2
noyau (Ping after 24h)
https://codereview.chromium.org/456793002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h File components/enhanced_bookmarks/enhanced_bookmark_utils.h (right): https://codereview.chromium.org/456793002/diff/1/components/enhanced_bookmarks/enhanced_bookmark_utils.h#newcode15 components/enhanced_bookmarks/enhanced_bookmark_utils.h:15: namespace enhanced_bookmark { On 2014/08/12 14:04:15, blundell wrote: > ...
6 years, 3 months ago (2014-08-27 09:35:39 UTC) #3
blundell
lgtm
6 years, 3 months ago (2014-08-27 12:33:12 UTC) #4
noyau (Ping after 24h)
The CQ bit was checked by noyau@chromium.org
6 years, 3 months ago (2014-08-27 12:37:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noyau@chromium.org/456793002/20001
6 years, 3 months ago (2014-08-27 12:37:28 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 14:04:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (20001) as 55ef8c4a8745f12923ab85110d851bb178a8ac81
6 years, 3 months ago (2014-08-27 14:43:37 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9da9612482b2028dff0f1caca783878e8aa82abc
Cr-Commit-Position: refs/heads/master@{#292150}

Powered by Google App Engine
This is Rietveld 408576698