Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 456753002: Change variable name for 'border-image-width' (Closed)

Created:
6 years, 4 months ago by je_julie(Not used)
Modified:
6 years, 4 months ago
Reviewers:
tonyg
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change variable name for 'border-image-width' The 'border-image' has 'border-image-source', 'border-image-slice', 'border-image-width', 'border-image-outset' and 'border-image-repeat'. http://www.w3.org/TR/css3-background/ m_imageSlice is for 'border-image-slice' and m_borderSlice is for 'border-image-width'. It causes confusion between m_borderSlice and m_imageSlice. This patch changes m_borderSlice to m_borderWidth along with property name. BUG= R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
je_julie(Not used)
PTAL
6 years, 4 months ago (2014-08-08 13:26:24 UTC) #1
tonyg
lgtm
6 years, 4 months ago (2014-08-09 17:53:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/456753002/1
6 years, 4 months ago (2014-08-09 17:54:29 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-09 18:49:35 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 19:43:54 UTC) #5
Message was sent while issue was closed.
Change committed as 179887

Powered by Google App Engine
This is Rietveld 408576698