Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 456743002: Invert the pass condition of fullscreen/full-screen-render-inline-expected.html (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Invert the pass condition of fullscreen/full-screen-render-inline-expected.html The bug hasn't been fixed, but now any unrelated change to the test result will result in a failure, instead of being silently ignored. BUG=246077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-render-inline-expected.html View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-08 13:09:11 UTC) #1
falken
LGTM, thanks!
6 years, 4 months ago (2014-08-11 02:35:12 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-11 07:13:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/456743002/1
6 years, 4 months ago (2014-08-11 07:14:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 07:51:42 UTC) #5
Message was sent while issue was closed.
Change committed as 179914

Powered by Google App Engine
This is Rietveld 408576698