Issue 456733003: Remove the acceleratedCompositingForCanvas setting.

Issue 456733003: Remove the acceleratedCompositingForCanvas setting. (Closed)

Created:
6 years, 4 months ago by danakj

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jamesr, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr., rune+blink, senorblanco, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove the acceleratedCompositingForCanvas setting. Instead, choose to promote if the canvas element is accelerated. R=abarth BUG=364908 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179849

Patch Set 1 #

Patch Set 2 : rm-compositingforcanvas: . #

Patch Set 3 : rm-compositingforcanvas: . #

Patch Set 4 : rm-compositingforcanvas: . #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -28 lines)			Patch
M	Source/core/frame/Settings.in	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderHTMLCanvas.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderHTMLCanvas.cpp	View	1 2 3	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderPart.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderPart.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderVideo.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderVideo.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/compositing/CompositingReasonFinder.cpp	View	1 2 3	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/rendering/compositing/CompositingTriggers.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebSettings.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

danakj

Oh we can do one better, I removed the CanvasTrigger also. The RenderHTMLCanvas::additionalCompositingReasons decides to ...

6 years, 4 months ago (2014-08-08 15:18:54 UTC) #2

danakj

And I'll raise myself one more. This was the last additionalCompositingReasons() method that actually used ...

6 years, 4 months ago (2014-08-08 15:23:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/456733003/60001

6 years, 4 months ago (2014-08-08 15:46:22 UTC) #6

Message was sent while issue was closed.

Change committed as 179849

Expand Messages | Collapse Messages