Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp

Issue 456683002: bindings: Introduces type-check for the internal pointers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp b/Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
index 7e09af1825052d6eaf06ab272f7cf8aa801262af..9314c841dacba2766543a83a55f3c873d7b93642 100644
--- a/Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
@@ -117,7 +117,7 @@ v8::Handle<v8::Object> V8TestInterfaceEventTarget::findInstanceInPrototypeChain(
TestInterfaceEventTarget* V8TestInterfaceEventTarget::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)
{
- return hasInstance(value, isolate) ? fromInternalPointer(v8::Handle<v8::Object>::Cast(value)->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) : 0;
+ return hasInstance(value, isolate) ? fromInternalPointer(blink::toInternalPointer(v8::Handle<v8::Object>::Cast(value))) : 0;
}
EventTarget* V8TestInterfaceEventTarget::toEventTarget(v8::Handle<v8::Object> object)
@@ -152,10 +152,10 @@ v8::Handle<v8::Object> V8TestInterfaceEventTarget::createWrapper(PassRefPtrWillB
return wrapper;
}
-void V8TestInterfaceEventTarget::derefObject(void* object)
+void V8TestInterfaceEventTarget::derefObject(ScriptWrappableBase* internalPointer)
{
#if !ENABLE(OILPAN)
- fromInternalPointer(object)->deref();
+ fromInternalPointer(internalPointer)->deref();
#endif // !ENABLE(OILPAN)
}

Powered by Google App Engine
This is Rietveld 408576698