Issue 456653002: Video Player: Show a checkmark on the currently playing device in cast menu

Issue 456653002: Video Player: Show a checkmark on the currently playing device in cast menu (Closed)

Created:
6 years, 4 months ago by yoshiki

Modified:
6 years, 4 months ago

Reviewers:
hirono

CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Video Player: Show a checkmark on the currently playing device in cast menu This patch adds a checkmark which is at the left of the currenly playing device on the cast menu. BUG=none TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288325

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the comment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
	M	ui/file_manager/video_player/css/cast_menu.css	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
	M	ui/file_manager/video_player/js/video_player.js	View		2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

hirono

lgtm with a nit. https://codereview.chromium.org/456653002/diff/10004/ui/file_manager/video_player/css/cast_menu.css File ui/file_manager/video_player/css/cast_menu.css (right): https://codereview.chromium.org/456653002/diff/10004/ui/file_manager/video_player/css/cast_menu.css#newcode30 ui/file_manager/video_player/css/cast_menu.css:30: -webkit-padding-start: 0px; nit: We emit ...

6 years, 4 months ago (2014-08-08 07:37:28 UTC) #4

yoshiki

Thanks. https://codereview.chromium.org/456653002/diff/10004/ui/file_manager/video_player/css/cast_menu.css File ui/file_manager/video_player/css/cast_menu.css (right): https://codereview.chromium.org/456653002/diff/10004/ui/file_manager/video_player/css/cast_menu.css#newcode30 ui/file_manager/video_player/css/cast_menu.css:30: -webkit-padding-start: 0px; On 2014/08/08 07:37:28, hirono wrote: > ...

6 years, 4 months ago (2014-08-08 07:43:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/456653002/50001

6 years, 4 months ago (2014-08-08 07:45:38 UTC) #7

Message was sent while issue was closed.

Change committed as 288325

Expand Messages | Collapse Messages