Oilpan: Assert that updator functions of HashMap, HashSet, and Vector should not be used during wea…

Oilpan: Assert that updator functions of HashMap, HashSet, and Vector should not be used during weak processing.

We already have assertions in Heap::allocate and Heap::reallocate. However the
member functions of HashMap, HashSet, and Vector don't always call
Heap::allocate or Heap::reallocate, and it's very hard to detect
allocation-in-weak-processing.

BUG=400652
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179899

[tkent, 2014-08-11 00:46:52]

Please review this.

[haraken, 2014-08-11 00:49:44]

Can we add the ASSERT further down the call stack (e.g., expand(),
expandCapacity() etc)?

[tkent, 2014-08-11 01:52:03]

On 2014/08/11 00:49:44, haraken wrote:
> Can we add the ASSERT further down the call stack (e.g., expand(),
> expandCapacity() etc)?

We already have assertions in Heap::allocate and Heap::reallocate, which are
much lower.
The purpose of this CL is to assert even if expand/expandCapacity is NOT called.

[haraken, 2014-08-11 01:52:43]

On 2014/08/11 01:52:03, tkent wrote:
> On 2014/08/11 00:49:44, haraken wrote:
> > Can we add the ASSERT further down the call stack (e.g., expand(),
> > expandCapacity() etc)?
> 
> We already have assertions in Heap::allocate and Heap::reallocate, which are
> much lower.
> The purpose of this CL is to assert even if expand/expandCapacity is NOT
called.

Makes sense. LGTM.

[tkent, 2014-08-11 02:10:26]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-08-11 02:10:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/456633002/1

[commit-bot: I haz the power, 2014-08-11 02:14:12]

Change committed as 179899

[Mads Ager (chromium), 2014-08-11 06:33:31]

LGTM!

[zerny-chromium, 2014-08-11 07:28:53]

lgtm2. thanks!