Issue 456623003: Disable Screen Orientation API on Win8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456623003: Disable Screen Orientation API on Win8. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 4 months ago

Reviewers:
Avi (use Gerrit), jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, Miguel Garcia

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable Screen Orientation API on Win8. This is a temporary measure until: - we can disable the API only on Win8 Metro OR, - we can make it work on Win8 Metro. The API is currently broken on Win8 Metro and it is not trivial to disable it on that mode only. Given the discussion with the Blink API owners, disabling it on Win8 would be better than not shipping because of the bug on Win8 Metro. BUG=400846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288371

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix compilation #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	content/browser/screen_orientation/screen_orientation_browsertest.cc	View	1 2	4 chunks	+30 lines, -0 lines	0 comments	Download
	M	content/child/runtime_features.cc	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 4 months ago (2014-08-08 15:29:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/456623003/40001

6 years, 4 months ago (2014-08-08 15:30:08 UTC) #5

Message was sent while issue was closed.

Change committed as 288371

Expand Messages | Collapse Messages