Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 456623002: bindings: Makes DOMMatrixReadOnly inherit from ScriptWrappableBase. (Closed)

Created:
6 years, 4 months ago by Yuki
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

bindings: Makes DOMMatrixReadOnly inherit from ScriptWrappableBase. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Yuki
Could you review this CL?
6 years, 4 months ago (2014-08-08 07:00:19 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-08 07:02:32 UTC) #2
haraken
Let me confirm: If we forget to make some object inherit from ScriptWrappableBase, we can ...
6 years, 4 months ago (2014-08-08 07:03:47 UTC) #3
Yuki
On 2014/08/08 07:03:47, haraken wrote: > Let me confirm: If we forget to make some ...
6 years, 4 months ago (2014-08-08 07:07:46 UTC) #4
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 4 months ago (2014-08-08 07:07:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/456623002/1
6 years, 4 months ago (2014-08-08 07:09:34 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:39:10 UTC) #7
Message was sent while issue was closed.
Change committed as 179803

Powered by Google App Engine
This is Rietveld 408576698