Issue 4565001: Add Canary to the channel switching UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4565001: Add Canary to the channel switching UI. (Closed)

Created:
10 years, 1 month ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org, adlr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add Canary to the channel switching UI. The change depends on http://codereview.chromium.org/4520001/show BUG=chromium-os:8384 TEST=confirmed that Canary appeared in the channel switching UI in Chrome built with branding=Chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65789

Patch Set 2 : canary-channel #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options/about_page_handler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/options/about_page.html	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM after you change the channel name to "canary-channel". Thanks! http://codereview.chromium.org/4565001/diff/1/4 File chrome/browser/resources/options/about_page.html (right): http://codereview.chromium.org/4565001/diff/1/4#newcode28 ...

10 years, 1 month ago (2010-11-05 16:46:16 UTC) #2

satorux1

10 years, 1 month ago (2010-11-11 10:35:27 UTC) #3

http://codereview.chromium.org/4565001/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/about_page.html (right):

http://codereview.chromium.org/4565001/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/about_page.html:28: <option
value="test-channel" i18n-content="canary"></option>
On 2010/11/05 16:46:16, petkov wrote:
> Change "test-channel" to "canary-channel".
> 

Done.

Expand Messages | Collapse Messages

Issue 4565001: Add Canary to the channel switching UI. (Closed)

Description

Patch Set 1 #

Patch Set 2 : canary-channel #

Messages