Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: build/android/gyp/strip_library_for_device.py

Issue 456493002: Add native libraries to gn apks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import json
8 import optparse 7 import optparse
9 import os 8 import os
10 import sys 9 import sys
11 10
12 from util import build_utils 11 from util import build_utils
13 12
14 13
15 def StripLibrary(android_strip, android_strip_args, library_path, output_path): 14 def StripLibrary(android_strip, android_strip_args, library_path, output_path):
16 if build_utils.IsTimeStale(output_path, [library_path]): 15 if build_utils.IsTimeStale(output_path, [library_path]):
17 strip_cmd = ([android_strip] + 16 strip_cmd = ([android_strip] +
18 android_strip_args + 17 android_strip_args +
19 ['-o', output_path, library_path]) 18 ['-o', output_path, library_path])
20 build_utils.CheckOutput(strip_cmd) 19 build_utils.CheckOutput(strip_cmd)
21 20
22 21
newt (away) 2014/08/11 23:55:23 please save extra newline for use elsewhere
cjhopman 2014/08/18 01:21:11 Done.
23 22
24 def main(): 23 def main(args):
24 args = build_utils.ExpandFileArgs(args)
25
25 parser = optparse.OptionParser() 26 parser = optparse.OptionParser()
27 build_utils.AddDepfileOption(parser)
26 28
27 parser.add_option('--android-strip', 29 parser.add_option('--android-strip',
28 help='Path to the toolchain\'s strip binary') 30 help='Path to the toolchain\'s strip binary')
29 parser.add_option('--android-strip-arg', action='append', 31 parser.add_option('--android-strip-arg', action='append',
30 help='Argument to be passed to strip') 32 help='Argument to be passed to strip')
31 parser.add_option('--libraries-dir', 33 parser.add_option('--libraries-dir',
32 help='Directory for un-stripped libraries') 34 help='Directory for un-stripped libraries')
33 parser.add_option('--stripped-libraries-dir', 35 parser.add_option('--stripped-libraries-dir',
34 help='Directory for stripped libraries') 36 help='Directory for stripped libraries')
35 parser.add_option('--libraries-file', 37 parser.add_option('--libraries',
36 help='Path to json file containing list of libraries') 38 help='List of libraries to strip')
37 parser.add_option('--stamp', help='Path to touch on success') 39 parser.add_option('--stamp', help='Path to touch on success')
38 40
39 41
40 options, _ = parser.parse_args() 42 options, _ = parser.parse_args(args)
41 43
42 with open(options.libraries_file, 'r') as libfile: 44 libraries = build_utils.ParseGypList(options.libraries)
43 libraries = json.load(libfile)
44 45
45 build_utils.MakeDirectory(options.stripped_libraries_dir) 46 build_utils.MakeDirectory(options.stripped_libraries_dir)
46 47
47 for library in libraries: 48 for library in libraries:
48 for base_path in options.libraries_dir.split(','): 49 for base_path in options.libraries_dir.split(','):
49 library_path = os.path.join(base_path, library) 50 library_path = os.path.join(base_path, library)
50 if (os.path.exists(library_path)): 51 if (os.path.exists(library_path)):
51 break 52 break
52 stripped_library_path = os.path.join( 53 stripped_library_path = os.path.join(
53 options.stripped_libraries_dir, library) 54 options.stripped_libraries_dir, library)
54 StripLibrary(options.android_strip, options.android_strip_arg, library_path, 55 StripLibrary(options.android_strip, options.android_strip_arg, library_path,
55 stripped_library_path) 56 stripped_library_path)
56 57
57 if options.stamp: 58 if options.stamp:
58 build_utils.Touch(options.stamp) 59 build_utils.Touch(options.stamp)
59 60
60 61
61 if __name__ == '__main__': 62 if __name__ == '__main__':
62 sys.exit(main()) 63 sys.exit(main(sys.argv[1:]))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698