Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 456363002: DevTools: protocol: add "canEmulateNetworkConditions" method definition. (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: protocol: add "canEmulateNetworkConditions" method definition. BUG=396086 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/devtools/protocol.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eustas
6 years, 4 months ago (2014-08-11 10:29:25 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-11 11:14:08 UTC) #2
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 11:34:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/456363002/1
6 years, 4 months ago (2014-08-11 11:35:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 12:42:18 UTC) #5
dgozman
Please add BUG=396086.
6 years, 4 months ago (2014-08-11 13:04:59 UTC) #6
eustas
On 2014/08/11 13:04:59, dgozman wrote: > Please add BUG=396086. done
6 years, 4 months ago (2014-08-11 13:05:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 13:24:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22048)
6 years, 4 months ago (2014-08-11 13:24:49 UTC) #9
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 13:31:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/456363002/1
6 years, 4 months ago (2014-08-11 13:31:45 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 14:09:37 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:45:49 UTC) #13
Message was sent while issue was closed.
Change committed as 179957

Powered by Google App Engine
This is Rietveld 408576698