Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 456353002: DevTools: Removed unused method EmbeddedWorkerDevToolsManager::GetDevToolsAgentHostForServiceWorker (Closed)

Created:
6 years, 4 months ago by vkuzkokov
Modified:
6 years, 4 months ago
Reviewers:
pfeldman, yurys, horo
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Removed unused method EmbeddedWorkerDevToolsManager::GetDevToolsAgentHostForServiceWorker BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289068

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/browser/devtools/embedded_worker_devtools_manager.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
vkuzkokov
6 years, 4 months ago (2014-08-11 10:11:38 UTC) #1
yurys
Are you sure this method is unused? It was added quite recently, please talk to ...
6 years, 4 months ago (2014-08-11 11:17:52 UTC) #2
pfeldman
lgtm
6 years, 4 months ago (2014-08-11 11:18:07 UTC) #3
vkuzkokov
On 2014/08/11 11:17:52, yurys wrote: > Are you sure this method is unused? It was ...
6 years, 4 months ago (2014-08-11 11:40:14 UTC) #4
horo
lgtm. Thank you.
6 years, 4 months ago (2014-08-12 00:05:46 UTC) #5
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-12 07:15:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/456353002/1
6 years, 4 months ago (2014-08-12 07:16:52 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 10:38:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 12:23:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5837)
6 years, 4 months ago (2014-08-12 12:23:18 UTC) #10
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-12 15:08:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/456353002/1
6 years, 4 months ago (2014-08-12 15:10:59 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 15:16:41 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 15:21:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5914)
6 years, 4 months ago (2014-08-12 15:21:49 UTC) #15
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-12 15:40:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/456353002/20001
6 years, 4 months ago (2014-08-12 15:43:00 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-12 19:21:27 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 21:42:30 UTC) #19
Message was sent while issue was closed. 
Change committed as 289068

Powered by Google App Engine
This is Rietveld 408576698