LayoutTests/media/media-controller-effective-playback-rate.html - Issue 456343002: Relanding 'Always notify the MediaPlayer of any seek' patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/media-controller-effective-playback-rate.html

Issue 456343002: Relanding 'Always notify the MediaPlayer of any seek' patch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed test failure Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/controls-timeline-with-controller-expected.txt ('k') | LayoutTests/media/media-controller-effective-playback-rate-expected.txt » ('j') | LayoutTests/media/video-seek-to-current-position.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/media-controller-effective-playback-rate.html

diff --git a/LayoutTests/media/media-controller-effective-playback-rate.html b/LayoutTests/media/media-controller-effective-playback-rate.html

index 5dbdc9419568ee12fec781537f90953ca745eb18..0a292b1162f54a11789b2a79b87b6ee795bc4e29 100644

--- a/LayoutTests/media/media-controller-effective-playback-rate.html

+++ b/LayoutTests/media/media-controller-effective-playback-rate.html

@@ -13,7 +13,7 @@

// Set the rate on the media element so playback won't move forward.

video.playbackRate = 0;

- waitForEvent("canplay",canplay);

+ waitForEventOnce("canplay",canplay);

};

var canplay = function()

@@ -35,15 +35,14 @@

{

// Initiate playback and verify that time moves forward.

run("video.play()");

- waitForEventOnce("play", play);

+ waitForEventOnce("playing", function()

+ {

+ waitForEventOnce("timeupdate", timeupdate);

+ });

};

- var play = function()

+ var timeupdate = function()

{

- waitForEventOnce("timeupdate", timeupdate);

- };

- var timeupdate = function() {

testExpected("video.currentTime", 0, "!=");

endTest();

};