LayoutTests/media/controls-restrained-media-controller.html - Issue 456343002: Relanding 'Always notify the MediaPlayer of any seek' patch

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/controls-restrained-media-controller.html

Issue 456343002: Relanding 'Always notify the MediaPlayer of any seek' patch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed test failure Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>controls of a non-blocked and a blocked media element slaved to a media c ontroller</title>	2 <title>controls of a non-blocked and a blocked media element slaved to a media c ontroller</title>

3 <script src="media-file.js"></script>	3 <script src="media-file.js"></script>

4 <video mediagroup="x" controls></video>	4 <video mediagroup="x" controls></video>

5 <!-- This video will stay in readyState HAVE_NOTHING, which before	5 <!-- This video will stay in readyState HAVE_NOTHING, which before

6 https://www.w3.org/Bugs/Public/show_bug.cgi?id=25429 would cause the media	6 https://www.w3.org/Bugs/Public/show_bug.cgi?id=25429 would cause the media

7 controller to not be a restrained media controller, which would make the	7 controller to not be a restrained media controller, which would make the

8 activation behavior (toggle play/pause) do the wrong thing. -->	8 activation behavior (toggle play/pause) do the wrong thing. -->

9 <video mediagroup="x" hidden></video>	9 <video mediagroup="x" hidden></video>

10 <script>	10 <script>

11 var video = document.querySelector('video[controls]');	11 var video = document.querySelector('video[controls]');

12 video.src = findMediaFile('video', 'content/test');	12 video.src = findMediaFile('video', 'content/test');

13	13

14 if (window.testRunner) {	14 if (window.testRunner) {

15 testRunner.waitUntilDone();	15 testRunner.waitUntilDone();

16 video.addEventListener('canplay', function() {	16 window.setTimeout(function() {
	philipj_slow 2014/12/15 14:52:38 Having a timeout is a recipe for future flakiness. Having a timeout is a recipe for future flakiness. From the failure it looks like we're not guaranteed to have decoded and painted the first frame in the canplay event, which seems very odd. It also seems to have failed on all bots, so is it actually flaky? The test doesn't even explicitly set currentTime, so how is it related to the change this CL makes?
17 testRunner.notifyDone();	17 testRunner.notifyDone();

18 });	18 }, 100);

19 }	19 }

20 </script>	20 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/controls-timeline-with-controller.html » ('j') | no next file with comments »