Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/PrivateScriptRunner.cpp
diff --git a/Source/bindings/core/v8/PrivateScriptRunner.cpp b/Source/bindings/core/v8/PrivateScriptRunner.cpp
index 373e77bc9de3384a8bc80943c5efe2122ea801e8..0e75bbc4b579c42145382bb03d04868c30a37225 100644
--- a/Source/bindings/core/v8/PrivateScriptRunner.cpp
+++ b/Source/bindings/core/v8/PrivateScriptRunner.cpp
@@ -257,6 +257,16 @@ bool PrivateScriptRunner::rethrowExceptionInPrivateScript(v8::Isolate* isolate,
messageString = toCoreString(v8::Handle<v8::String>::Cast(message));
String exceptionName = toCoreString(v8::Handle<v8::String>::Cast(name));
+ {
+ // FIXME: remove this.
+ // This is a temporal hack to show the error message.
+ //v8::Handle<v8::Value> lineNumber = exceptionObject->Get(v8String(isolate, "lineNumber"));
+ v8::Handle<v8::Value> message = exceptionObject->Get(v8String(isolate, "message"));
+ String messageStr = toCoreString(v8::Handle<v8::String>::Cast(message));
+
+ printf("JavaScript Error!\n");
+ printf("message: %s\n", messageStr.utf8().data());
+ }
if (exceptionName == "DOMExceptionInPrivateScript") {
v8::Handle<v8::Value> code = exceptionObject->Get(v8String(isolate, "code"));
RELEASE_ASSERT(!code.IsEmpty() && code->IsInt32());
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698