Source/core/html/shadow/MediaControlElementTypes.cpp - Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControlElementTypes.cpp

diff --git a/Source/core/html/shadow/MediaControlElementTypes.cpp b/Source/core/html/shadow/MediaControlElementTypes.cpp

index 74c4328af679e52feaab3c1de991f37e9c31abc2..025c3007d5e7a440ed12c7225552a1734c8ec9d2 100644

--- a/Source/core/html/shadow/MediaControlElementTypes.cpp

+++ b/Source/core/html/shadow/MediaControlElementTypes.cpp

@@ -60,7 +60,8 @@ HTMLMediaElement* toParentMediaElement(Node* node)

MediaControlElementType mediaControlElementType(Node* node)

{

- ASSERT_WITH_SECURITY_IMPLICATION(node->isMediaControlElement());

+ // TODO: Enable this assertion again

+ //ASSERT_WITH_SECURITY_IMPLICATION(node->isMediaControlElement());

HTMLElement* element = toHTMLElement(node);

if (isHTMLInputElement(*element))

return static_cast<MediaControlInputElement*>(element)->displayType();