Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: Source/core/html/HTMLVideoElement.cpp

Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLVideoElement.cpp
diff --git a/Source/core/html/HTMLVideoElement.cpp b/Source/core/html/HTMLVideoElement.cpp
index 11fc26286364b76f8c09e42c6dc23499f3a08b8a..cfc89d2545bb2af3d3ecb3ede3a044db7d4602b8 100644
--- a/Source/core/html/HTMLVideoElement.cpp
+++ b/Source/core/html/HTMLVideoElement.cpp
@@ -27,8 +27,11 @@
#include "core/html/HTMLVideoElement.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/PrivateScriptRunner.h"
+#include "bindings/core/v8/V8HTMLVideoElement.h"
#include "core/CSSPropertyNames.h"
#include "core/HTMLNames.h"
+#include "core/dom/ActiveDOMObject.h"
#include "core/dom/Attribute.h"
#include "core/dom/Document.h"
#include "core/dom/ExceptionCode.h"
@@ -53,6 +56,8 @@ inline HTMLVideoElement::HTMLVideoElement(Document& document)
: HTMLMediaElement(videoTag, document)
{
ScriptWrappable::init(this);
+ //v8::Handle<v8::Value> classObject = PrivateScriptRunner::installClassIfNeeded(document.frame(), "HTMLVideoElement");
+ //RELEASE_ASSERT(!classObject.IsEmpty());
haraken 2014/08/11 11:09:33 I guess this won't be needed.
if (document.settings())
m_defaultPosterURL = AtomicString(document.settings()->defaultVideoPosterURL());
}
@@ -62,6 +67,7 @@ PassRefPtrWillBeRawPtr<HTMLVideoElement> HTMLVideoElement::create(Document& docu
RefPtrWillBeRawPtr<HTMLVideoElement> video = adoptRefWillBeNoop(new HTMLVideoElement(document));
video->ensureUserAgentShadowRoot();
video->suspendIfNeeded();
+ ScriptForbiddenScope::AllowUserAgentScript script;
haraken 2014/08/11 11:09:33 What is this for?
return video.release();
}

Powered by Google App Engine
This is Rietveld 408576698