Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/PrivateScriptRunner.cpp
diff --git a/Source/bindings/core/v8/PrivateScriptRunner.cpp b/Source/bindings/core/v8/PrivateScriptRunner.cpp
index ff3a7bb32030cb2abad66cb4e5c4c3f7fb1538a8..a95408a8d800781fa62e13801fd61202e5db9e33 100644
--- a/Source/bindings/core/v8/PrivateScriptRunner.cpp
+++ b/Source/bindings/core/v8/PrivateScriptRunner.cpp
@@ -186,6 +186,13 @@ bool PrivateScriptRunner::throwDOMExceptionInPrivateScriptIfNeeded(v8::Isolate*
if (name.IsEmpty() || !name->IsString())
return false;
String exceptionName = toCoreString(v8::Handle<v8::String>::Cast(name));
+ {
+ // FIXME: remove this.
+ // This is a temporal hack to show the error message.
+ v8::Handle<v8::Value> message = exceptionObject->Get(v8String(isolate, "message"));
+ String messageStr = toCoreString(v8::Handle<v8::String>::Cast(message));
+ printf("message: %s\n", messageStr.utf8().data());
+ }
if (exceptionName == "DOMExceptionInPrivateScript") {
v8::Handle<v8::Value> message = exceptionObject->Get(v8String(isolate, "message"));
RELEASE_ASSERT(!message.IsEmpty() && message->IsString());
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/dom/Element.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698