Source/core/html/HTMLMediaElement.idl - Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS

Side by Side Diff: Source/core/html/HTMLMediaElement.idl

Issue 456323002: [WIP] Re-implement MediaControls in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/dom/Element.idl ('K') | « Source/core/dom/Element.idl ('k') | Source/core/html/HTMLVideoElement.cpp » ('j') | Source/core/html/HTMLVideoElement.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2010, 2011, 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2010, 2011, 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 readonly attribute TextTrackList textTracks;	87 readonly attribute TextTrackList textTracks;

88 [RaisesException] TextTrack addTextTrack(DOMString kind, optional DOMString label, optional DOMString language);	88 [RaisesException] TextTrack addTextTrack(DOMString kind, optional DOMString label, optional DOMString language);

89	89

90 // WebKit extensions	90 // WebKit extensions

91	91

92 // The number of bytes consumed by the media decoder.	92 // The number of bytes consumed by the media decoder.

93 [MeasureAs=PrefixedAudioDecodedByteCount] readonly attribute unsigned long w ebkitAudioDecodedByteCount;	93 [MeasureAs=PrefixedAudioDecodedByteCount] readonly attribute unsigned long w ebkitAudioDecodedByteCount;

94 [MeasureAs=PrefixedVideoDecodedByteCount] readonly attribute unsigned long w ebkitVideoDecodedByteCount;	94 [MeasureAs=PrefixedVideoDecodedByteCount] readonly attribute unsigned long w ebkitVideoDecodedByteCount;

95	95

96 [Reflect, RuntimeEnabled=SubresourceIntegrity] attribute DOMString integrity ;	96 [Reflect, RuntimeEnabled=SubresourceIntegrity] attribute DOMString integrity ;

	97

	98 [OnlyExposedToPrivateScript] boolean hasVideo();

	99 [OnlyExposedToPrivateScript] boolean hasAudio();
	abarth-chromium 2014/08/11 18:04:12 Why is this needed? We should avoid introducing O Why is this needed? We should avoid introducing OnlyExposedToPrivateScript back doors when implementing these features. philipj_slow 2014/08/11 19:40:15 If things were hooked up just a little bit more in Show quoted text On 2014/08/11 18:04:12, abarth wrote: > Why is this needed? We should avoid introducing OnlyExposedToPrivateScript back > doors when implementing these features. If things were hooked up just a little bit more internally, it should be possible to use the audioTracks and videoTracks lists instead. hajimehoshi 2014/08/12 06:54:09 Hmm, I wasn't sure how to get the same results of Show quoted text On 2014/08/11 19:40:15, philipj wrote: > On 2014/08/11 18:04:12, abarth wrote: > > Why is this needed? We should avoid introducing OnlyExposedToPrivateScript > back > > doors when implementing these features. > > If things were hooked up just a little bit more internally, it should be > possible to use the audioTracks and videoTracks lists instead. Hmm, I wasn't sure how to get the same results of hasAudio/hasVideo by audioTracks/videoTracks. I moved them to MediaControls.idl once. MediaControls.idl is only for internal usage, so this seems much better than defining them here. philipj_slow 2014/08/12 08:27:48 AudioVideoTracks is still status=experimental, so Show quoted text On 2014/08/12 06:54:09, hajimehoshi wrote: > On 2014/08/11 19:40:15, philipj wrote: > > On 2014/08/11 18:04:12, abarth wrote: > > > Why is this needed? We should avoid introducing OnlyExposedToPrivateScript > > back > > > doors when implementing these features. > > > > If things were hooked up just a little bit more internally, it should be > > possible to use the audioTracks and videoTracks lists instead. > > Hmm, I wasn't sure how to get the same results of hasAudio/hasVideo by > audioTracks/videoTracks. > > I moved them to MediaControls.idl once. MediaControls.idl is only for internal > usage, so this seems much better than defining them here. AudioVideoTracks is still status=experimental, so I guess we can't depend on it. If it were enabled, HTMLMediaElement::createPlaceholderTracksIfNecessary() ought to be enough to create the tracks if they are there, even if they won't contain any other useful info.
97 };	100 };

OLD	NEW