Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 456313003: Check HTMLMediaElement::supportsType() in MediaSource.isTypeSupported() (Closed)

Created:
6 years, 4 months ago by Henrik Steen
Modified:
5 years, 5 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Check HTMLMediaElement::supportsType() in MediaSource.isTypeSupported() MediaSource.isTypeSupported() should not return true without making sure that the HTMLMediaElement supports the content type as well. BUG=402386 R=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Henrik Steen
6 years, 4 months ago (2014-08-11 09:10:53 UTC) #1
philipj_slow
I've reviewed this internally and it seems reasonable, but I'm not knowledgeable enough about the ...
6 years, 4 months ago (2014-08-11 09:19:10 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm. Is there a specific bug that is being fixed here or is this just ...
6 years, 4 months ago (2014-08-11 18:04:09 UTC) #3
philipj_slow
Henrik has the details, but there was apparently a real scenario on our Devices SDK ...
6 years, 4 months ago (2014-08-11 19:38:57 UTC) #4
Henrik Steen
On 2014/08/11 19:38:57, philipj wrote: > Henrik has the details, but there was apparently a ...
6 years, 4 months ago (2014-08-11 19:57:18 UTC) #5
Henrik Steen
The CQ bit was checked by henriks@opera.com
6 years, 4 months ago (2014-08-12 05:01:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henriks@opera.com/456313003/1
6 years, 4 months ago (2014-08-12 05:01:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 05:38:22 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 06:41:47 UTC) #9
Message was sent while issue was closed.
Change committed as 180035

Powered by Google App Engine
This is Rietveld 408576698