Source/modules/webaudio/MediaElementAudioSourceNode.cpp - Issue 456273002: MediaElementAudioSourceNode::dispose() should call HTMLMediaElement::setAudioSourceNode(0) in oilpa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 456273002: MediaElementAudioSourceNode::dispose() should call HTMLMediaElement::setAudioSourceNode(0) in oilpa… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

diff --git a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

index 9bf19c8849481f963a4ad6945de4481bdf22bd78..320ff8c537cec1da7e4bee4d6cc7c3141f363a60 100644

--- a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

+++ b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -69,9 +69,7 @@ MediaElementAudioSourceNode::~MediaElementAudioSourceNode()

void MediaElementAudioSourceNode::dispose()

{

-#if !ENABLE(OILPAN)

m_mediaElement->setAudioSourceNode(0);

-#endif

uninitialize();

AudioSourceNode::dispose();

}

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »