Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 456233002: Use ScriptPromiseProperty::reset in ReadableStream. (Closed)

Created:
6 years, 4 months ago by yhirano
Modified:
6 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use ScriptPromiseProperty::reset in ReadableStream. As ScriptPromiseProperty::reset is implemented, ReadableStream now uses it and this CL removes FIXMEs about it. BUG=393911 R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M Source/core/streams/ReadableStream.cpp View 5 chunks +9 lines, -18 lines 0 comments Download
M Source/core/streams/ReadableStreamTest.cpp View 4 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yhirano
6 years, 4 months ago (2014-08-11 04:39:16 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 4 months ago (2014-08-11 07:37:14 UTC) #2
yhirano
+tkent for OWNER review.
6 years, 4 months ago (2014-08-11 07:45:43 UTC) #3
tkent
rslgtm
6 years, 4 months ago (2014-08-11 07:49:53 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-11 07:52:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/456233002/1
6 years, 4 months ago (2014-08-11 07:52:44 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:50:17 UTC) #7
Message was sent while issue was closed.
Change committed as 179926

Powered by Google App Engine
This is Rietveld 408576698