Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4419)

Unified Diff: chrome/common/extensions/api/notification_provider.idl

Issue 456223002: Add NotifyOnShowSettings implementation of notification provider API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments (JavaScript format) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/notification_provider.idl
diff --git a/chrome/common/extensions/api/notification_provider.idl b/chrome/common/extensions/api/notification_provider.idl
index 4220f4057fae2dc42599dd3ea6e9343233e56755..435615b5a932ecab4b8cc34fc85e1afc417fcc54 100644
--- a/chrome/common/extensions/api/notification_provider.idl
+++ b/chrome/common/extensions/api/notification_provider.idl
@@ -21,7 +21,21 @@ namespace notificationProvider {
denied
};
+ enum NotifierType {
+ // Notifiers that are extensions or applications.
+ application,
+
+ // Notifiers that are webistes.
+ web
+ };
+
dictionary Notifier {
+ // Id of the notifier.
+ DOMString notifierId;
+
+ // Type of the notifier.
+ NotifierType type;
+
// Name of the notifier.
DOMString name;
@@ -41,10 +55,9 @@ namespace notificationProvider {
callback NotifyOnButtonClickedCallback = void (boolean matchExists);
- callback NotifyOnPermissionLevelChangedCallback =
- void (boolean notifierExists);
+ callback NotifyOnPermissionLevelChangedCallback = void (boolean wasChanged);
- callback NotifyOnShowSettingsCallback = void (boolean notifierExists);
+ callback NotifyOnShowSettingsCallback = void (boolean hasSettings);
callback GetNotifierCallback = void (Notifier notifier);
@@ -84,18 +97,22 @@ namespace notificationProvider {
// Inform the notifier that the user changed the permission level of that
// notifier.
// |notifierId|: The id of the notifier that sent the notification.
+ // |notifierType|: The type of the notifier that sent the notification.
// |level|: The perission level of the notifier
- // |callback|: Called to indicate whether the notifier existed.
+ // |callback|: Called to indicate whether the permission level was changed.
static void notifyOnPermissionLevelChanged(
DOMString notifierId,
+ NotifierType notifierType,
NotifierPermissionLevel level,
NotifyOnPermissionLevelChangedCallback callback);
// Inform the notifier that the user chose to see advanced settings of that
// notifier.
// |notifierId|: The id of the notifier that sent the notification.
- // |callback|: Called to indicate whether a matching notifier existed.
+ // |notifierType|: The type of the notifier that sent the notification.
+ // |callback|: Called to indicate whether the notifier has extra settings.
static void notifyOnShowSettings(DOMString notifierId,
+ NotifierType notifierType,
NotifyOnShowSettingsCallback callback);
// To get a notifier from it's notifier ID.

Powered by Google App Engine
This is Rietveld 408576698