Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6410)

Unified Diff: chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc

Issue 456223002: Add NotifyOnShowSettings implementation of notification provider API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc b/chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc
index 0e8ffb8e1e827e433b93494a35dbfe698e6db52f..b060881a3a7f56a02e06fb2f9428ccf8aa790fd0 100644
--- a/chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc
+++ b/chrome/browser/extensions/api/notification_provider/notification_provider_apitest.cc
@@ -54,27 +54,6 @@ IN_PROC_BROWSER_TEST_F(NotificationProviderApiTest, Events) {
}
IN_PROC_BROWSER_TEST_F(NotificationProviderApiTest, TestBasicUsage) {
- // set up content of a notification
- std::string sender_id1 = "SenderId";
- std::string notification_id1 = "NotificationId";
-
- scoped_ptr<extensions::api::notifications::NotificationOptions> options(
- new extensions::api::notifications::NotificationOptions());
- CreateNotificationOptionsForTest(options.get());
-
- ResultCatcher catcher;
- catcher.RestrictToProfile(browser()->profile());
-
- // Test notification provider extension
- const extensions::Extension* extension = LoadExtension(
- test_data_dir_.AppendASCII("notification_provider/basic_usage"));
- ASSERT_TRUE(extension);
-
- scoped_ptr<extensions::NotificationProviderEventRouter> event_router(
- new extensions::NotificationProviderEventRouter(browser()->profile()));
-
- event_router->CreateNotification(
- extension->id(), sender_id1, notification_id1, *options);
-
- EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
+ ASSERT_TRUE(RunExtensionTest("notification_provider/basic_usage"))
+ << message_;
}

Powered by Google App Engine
This is Rietveld 408576698