Add NotifyOnShowSettings implementation of notification provider API

chrome/test/data/extensions/api_test/notification_provider/basic_usage/background.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 const notificationProvider = chrome.notificationProvider;
 
 function createNotification(notificationId, options) {
   return new Promise(function (resolve, reject) {
     chrome.notifications.create(notificationId, options, function (id) {
       if (chrome.runtime.lastError) {
@@ skipping 79 matching lines @@
       resolve(notifierExists);
       return;
     });
   });
 };
 
 function failTest(testName) {
   chrome.test.fail(testName);
 };
 
+function listenForShowSettings() {}
+
 function testFunctions() {
   var myId = chrome.runtime.id;
   var id1 = "id1";
   var returnId = myId + "-" + id1;
   var content = {
     type: "basic",
     iconUrl: "icon.png",
     title: "Title",
     message: "This is the message."
   };
 
+  // Add listener to onShowSettings to show that this extension has advanced
+  // settings.
+  chrome.notifications.onShowSettings.addListener(listenForShowSettings);
+
   // Create a notification, so there will be one existing notification
   createNotification(id1, content)

[dewittj, 2014/08/12 18:21:05]

it would be better if this test also verified that the various events in the
notifications API actually fired.

[liyanhou, 2014/08/13 21:06:26]

Done.

     .catch(function() { failTest("notifications.create"); })
     // Notify the sender that a notificaion was clicked.
     .then(function() { return notifyOnClicked(myId, returnId); })
-    .catch(function() { failTest("NotifyOnClicked1"); })
+    .catch(function() { failTest("NotifyOnClicked"); })
     // Try to notify that an non-existent notification was clicked.
     .then(function() { return notifyOnClicked(myId, "doesNotExist"); })
     // Fail if it returns true.
-    .then(function() { failTest("NotifyOnClicked2"); })
+    .then(function() { failTest("NotifyOnClicked"); })
     // Notify the sender that a notificaion button was clicked.
     .catch(function() { return notifyOnButtonClicked(myId, returnId, 0); })
     .catch(function() { failTest("NotifyOnButtonClicked"); })
     // Try to notify that a non-existent notification button was clicked.
     .then(function() { return notifyOnButtonClicked(myId, "doesNotExist", 0)})
     .then(function() { failTest("NotifyOnButtonClicked"); })
     // Try to notify that an non-existent notification was cleared.
     .catch(function () { return notifyOnCleared(myId, "doesNotExist"); })
     .then(function() { failTest("NotifyOnCleared"); })
     // Notify that the original notification was cleared.
     .catch(function() { return notifyOnCleared(myId, returnId); })
     .catch(function() { failTest("NotifyOnCleared"); })
+    // Notify the sender that the permission level is changed by the user
     .then(function () { return notifyOnPermissionLevelChanged(myId,
                                                               "granted"); })
     .catch(function() { failTest("NotifyOnPermissionLevelChanged"); })
     .then(function () { return notifyOnShowSettings(myId); })
     .catch(function() { failTest("NotifyOnShowSettings"); })
-    .then(function() { chrome.test.succeed(); });
+    // Try to notify a non existent sender that a user checked its settings
+    .then(function () { return notifyOnShowSettings("DoesNotExist"); })
+    // Fail if it returns true
+    .then(function() { failTest("NotifyOnShowSettings"); })
+    .catch(function() { chrome.test.succeed(); })
 };
 
 chrome.test.runTests([ testFunctions ]);