Add NotifyOnShowSettings implementation of notification provider API

chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/notification_provider/notification_provider_api.h"
 
 #include "base/callback.h"
 #include "base/guid.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/common/chrome_version_info.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/features/feature.h"
 #include "ui/base/layout.h"
+#include "ui/message_center/message_center.h"
+#include "ui/message_center/notifier_settings.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
 NotificationProviderEventRouter::NotificationProviderEventRouter(
     Profile* profile)
     : profile_(profile) {
 }
 
 NotificationProviderEventRouter::~NotificationProviderEventRouter() {
@@ skipping 176 matching lines @@
 NotificationProviderNotifyOnShowSettingsFunction::
     ~NotificationProviderNotifyOnShowSettingsFunction() {
 }
 
 ExtensionFunction::ResponseAction
 NotificationProviderNotifyOnShowSettingsFunction::Run() {
   scoped_ptr<api::notification_provider::NotifyOnShowSettings::Params> params =
       api::notification_provider::NotifyOnShowSettings::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
+  message_center::NotifierSettingsProvider* settings_provider =
+      message_center::MessageCenter::Get()->GetNotifierSettingsProvider();

[dewittj, 2014/08/12 18:21:05]

This is better, but it feels like you are skipping a layer by going directly to
the message center instead of using the notification UI manager.  Can we add a
TODO to refactor the NotificationUIManager API so that it allows grabbing a
settings provider?

[liyanhou, 2014/08/13 21:06:26]

Done.

+
+  message_center::NotifierId notifier_id(
+      message_center::NotifierId::NotifierType::APPLICATION,
+      params->notifier_id);
+
+  bool has_advanced_settings =
+      settings_provider->NotifierHasAdvancedSettings(notifier_id);
+  if (has_advanced_settings)
+    settings_provider->OnNotifierAdvancedSettingsRequested(notifier_id, NULL);
   return RespondNow(ArgumentList(
-      api::notification_provider::NotifyOnShowSettings::Results::Create(true)));
+      api::notification_provider::NotifyOnShowSettings::Results::Create(
+          has_advanced_settings)));
 }
 
 NotificationProviderGetNotifierFunction::
     NotificationProviderGetNotifierFunction() {
 }
 
 NotificationProviderGetNotifierFunction::
     ~NotificationProviderGetNotifierFunction() {
 }
 
@@ skipping 15 matching lines @@
 
 ExtensionFunction::ResponseAction
 NotificationProviderGetAllNotifiersFunction::Run() {
   std::vector<linked_ptr<api::notification_provider::Notifier> > notifiers;
 
   return RespondNow(ArgumentList(
       api::notification_provider::GetAllNotifiers::Results::Create(notifiers)));
 }
 
 }  // namespace extensions