Issue 456203002: remove (now unneeded) legacy onDrawPicture variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 456203002: remove (now unneeded) legacy onDrawPicture variant (Closed)

Created:
6 years, 4 months ago by reed2

Modified:
6 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

remove (now unneeded) legacy onDrawPicture variant TBR=fmalita@google.com Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	include/core/SkCanvas.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	include/utils/SkProxyCanvas.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/456203002/1

6 years, 4 months ago (2014-08-10 18:21:45 UTC) #2

commit-bot: I haz the power

Change committed as 2e69d292e5a389db7d9264eb66172376692de8ca

6 years, 4 months ago (2014-08-10 18:28:51 UTC) #3

reed2

6 years, 4 months ago (2014-08-11 02:03:21 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/457253002/ by reed@chromium.org.

The reason for reverting is: still need to update ProfilingCanvas in blink.

Expand Messages | Collapse Messages