Issue 4562002: Add DEPS files in remoting subdirectories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4562002: Add DEPS files in remoting subdirectories. (Closed)

Created:
10 years, 1 month ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
awong, garykac

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add DEPS files in remoting subdirectories. This is to avoid unwanted dependencies between remoting modules. Also fixed libjingle includes to use full path, and removed some old includes. TEST=checkdeps BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65251

Patch Set 1 : - #

Patch Set 2 : - #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -31 lines)			Patch
M	remoting/DEPS	View	1 chunk	+4 lines, -10 lines	0 comments	Download
A	remoting/base/DEPS	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	remoting/base/decoder_vp8_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/base/encode_decode_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	remoting/client/DEPS	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	remoting/client/x11_client.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	remoting/host/DEPS	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	remoting/jingle_glue/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	remoting/jingle_glue/ssl_adapter.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/jingle_glue/ssl_socket_adapter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/jingle_glue/xmpp_socket_adapter.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	remoting/jingle_glue/xmpp_socket_adapter.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
A	remoting/protocol/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	remoting/protocol/connection_to_client_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/protocol/message_decoder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM if trys succeed

nice!

Expand Messages | Collapse Messages