ExtensionUpdater: Abstract ExtensionDownloader creation

chrome/browser/extensions/updater/extension_downloader.cc

Index: chrome/browser/extensions/updater/extension_downloader.cc
diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc
index 47c02bd7324e05c6320a02f94d746590d25aba69..850abc3a1ba4f9eb042729c688791d78484e7aca 100644
--- a/chrome/browser/extensions/updater/extension_downloader.cc
+++ b/chrome/browser/extensions/updater/extension_downloader.cc
@@ -176,8 +176,7 @@ ExtensionDownloader::ExtensionFetch::~ExtensionFetch() {}
 
 ExtensionDownloader::ExtensionDownloader(
     ExtensionDownloaderDelegate* delegate,
-    net::URLRequestContextGetter* request_context,
-    IdentityProvider* webstore_identity_provider)
+    net::URLRequestContextGetter* request_context)
     : OAuth2TokenService::Consumer(kTokenServiceConsumerId),
       delegate_(delegate),
       request_context_(request_context),
@@ -188,8 +187,7 @@ ExtensionDownloader::ExtensionDownloader(
       extensions_queue_(&kDefaultBackoffPolicy,
                         base::Bind(&ExtensionDownloader::CreateExtensionFetcher,
                                    base::Unretained(this))),
-      extension_cache_(NULL),
-      identity_provider_(webstore_identity_provider) {
+      extension_cache_(NULL) {
   DCHECK(delegate_);
   DCHECK(request_context_);
 }
@@ -279,6 +277,11 @@ void ExtensionDownloader::StartBlacklistUpdate(
   StartUpdateCheck(blacklist_fetch.Pass());
 }
 
+void ExtensionDownloader::SetWebstoreIdentityProvider(
+    scoped_ptr<IdentityProvider> identity_provider) {
+  identity_provider_ = identity_provider.Pass();

[Yoyo Zhou, 2014/08/11 23:19:28]

Use reset() or swap() here.

[Ken Rockot(use gerrit already), 2014/08/11 23:48:24]

Done.

+}
+
 bool ExtensionDownloader::AddExtensionData(const std::string& id,
                                            const Version& version,
                                            Manifest::Type extension_type,
@@ -746,7 +749,7 @@ void ExtensionDownloader::CreateExtensionFetcher() {
       // We should try OAuth2, but we have no token cached. This
       // ExtensionFetcher will be started once the token fetch is complete,
       // in either OnTokenFetchSuccess or OnTokenFetchFailure.
-      DCHECK(identity_provider_);
+      DCHECK(identity_provider_ != NULL);

[Yoyo Zhou, 2014/08/11 23:19:28]

nit: I think this is usually written DCHECK(identity_provider.get())

[Ken Rockot(use gerrit already), 2014/08/11 23:48:24]

Done.

       OAuth2TokenService::ScopeSet webstore_scopes;
       webstore_scopes.insert(kWebstoreOAuth2Scope);
       access_token_request_ =